~dr|z3d
@RN
@RN_
@StormyCloud
@T3s|4
@T3s|4_
@eyedeekay
@not_bob_afk
@orignal
@postman
%Liorar
+DeltaOreo
+Xeha
+bak83_
+cumlord
+hk
+mareki2p
+profetikla
+r00tobo_BNC
+uop23ip
+weko
An0nm0n
Arch
BrickWall
Danny
FreeRider
Irc2PGuest17210
Irc2PGuest72690
Meow
Nausicaa
Onn4l7h
Onn4|7h
Over1
acetone_
anon
anu
boonst
freenet
mareki2pb
poriori_
qend-irc2p
r3med1tz
radakayot__
segfault
shiver_
simprelay
solidx66
thetia
u5657
woodwose
dr|z3d
does this look saner, or am I making the same mistake here?
dr|z3d
b32 = reader.readLine();
dr|z3d
if (b32 == null) {return;}
zzz
same
dr|z3d
yeah, figured.
dr|z3d
so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d
well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d
what about checking the filesize instead?
dr|z3d
int fileLength = (int) file.length();
dr|z3d
if (fileLength == 0) {return;}
zzz
better
zzz
but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d
sure, I don't think it's something that'll affect most people.
dr|z3d
if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d
got a stacktrace zzz, bug report updated.