@eyedeekay
&eche|on
&kytv
&zzz
+R4SAS
+RN
+StormyCloud
+T3s|4
+dr|z3d
+goose2_
+hagen
+orignal
+postman
+weko
An0nm0n
Arch
Danny
DeltaOreo
DiCEy1904
FreefallHeavens
Irc2PGuest11229
Irc2PGuest48909
Irc2PGuest6753
Nausicaa
Onn4l7h
PenguinDriver
SoniEx2
T3s|4_
Teeed
acetone_
anon2
b3t4f4c3__
bak83
boonst
cumlord
dr4wd3
eyedeekay_bnc
goose2
hk
itsjustme
j6
not_bob_afk
numberwang
onon_1
poriori
profetikla
qend-irc2p
rapidash
shiver_
u5657
veiledwizard
w8rabbit
x74a6
dr|z3d
are we almost at the testing phase, big commits complete?
dr|z3d
*crickets*
zzz
I'll leave it to the boss to answer
zzz
but imho 'big changes done' not the same as 'recommended for testing'
zzz
for my part, I have no big changes in WIP or planned
dr|z3d
haha, the boss.
dr|z3d
thanks, anyways, I guess that's mostly a no, then.
dr|z3d
I mean, obviously we're always at the testing phase, I just wanted to know if there was any more disruptive code changes happening, but I think you've answered my question.
zzz
well, "disruptive" is really just to you, presumably, due to merge issues.
dr|z3d
that's a fair point.
zzz
in that category, I believe the banlist stuff is all going to get reverted
dr|z3d
not sure I bought into those changes wholesale, so I might be ok there. I'm also not convinced non-floodfills rejecting lookup requests is a particularly bad idea, either.
zzz
at the lowest level, I have several concerns in the netdb handlers, where the added code + subdbs + existing code is interacting poorly and I think results in security issues
zzz
any fixes may not be "big" but are a prerequisite to recommending broader testing
zzz
from me anyway
zzz
another concern: a whole lot of TODOs in the diff-from-release
zzz
along with questions, maybes, notsures, etc
dr|z3d
ok, that sounds like there's still plenty of work to do, then, to get the code into a good shape for release.
zzz
sure, but how that maps to a schedule I have no idea
eyedeekay
I have a big MR I will be filing today which should have the rest of the unnecessary changes taken out today, throttler revert will happen today, TODO's will either be updated or removed by Wednesday
dr|z3d
are you breaking that MR down into specific commits by sub-section, eyedeekay?
zzz
eyedeekay, I also found commented-out TODO FNDF.chanceOfFloodingOnOurOwn() added in 2.3.0 which is another headscratcher
eyedeekay
zzz that one's definitely coming out, already gone in the branch
eyedeekay
Each checkin is labeled with the classes it will affect
dr|z3d
eyedeekay: ok, great, thanks.
eyedeekay
Re: the banlist revert that's going to happen but I'm working on getting all the parts reconciled